fix: Fix CopyPreserveEncodingsTest.lazyNoNulls #11887
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67318403 |
✅ Deploy Preview for meta-velox canceled.
|
Yuhta
approved these changes
Dec 17, 2024
Yuhta
reviewed
Dec 17, 2024
| @@ -327,10 +327,11 @@ TEST_F(CopyPreserveEncodingsTest, flatNoNulls) { | |||
| TEST_F(CopyPreserveEncodingsTest, lazyNoNulls) { | |||
| auto lazyVector = vectorMaker_.lazyFlatVector<int32_t>( | |||
| 10, [](vector_size_t row) { return row; }); | |||
| auto copy = lazyVector->loadedVector()->copyPreserveEncodings(); | |||
There was a problem hiding this comment.
Maybe add a check that if someone trying to copy unloaded lazy, they still get an exception
Summary: facebookincubator#11855 updated LazyVector:: copyPreserveEncodings() but didn't update the unit test. This diff fixes the failing test. Reviewed By: Yuhta Differential Revision: D67318403
kagamiori
force-pushed
the
export-D67318403
branch
from
270dc70 to
f67f861
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67318403 |
|
This pull request has been merged in d9a9c21. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: #11855 updated LazyVector:: copyPreserveEncodings() but didn't update the unit test. This diff fixes the failing test.
Differential Revision: D67318403